Skip to content

Only Trigger PSProvideVerboseMessage in Advanced Scripts or Functions #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Only Trigger PSProvideVerboseMessage in Advanced Scripts or Functions #99

wants to merge 1 commit into from

Conversation

GoodOlClint
Copy link
Contributor

Community rule OUT-04

The comment on line 44 seems like this was already the intended behavior, but the rule appears to be triggering regardless if [CmdletBinding()] is specified or not.

@msftclas
Copy link

msftclas commented May 6, 2015

Hi @GoodOlClint, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@yutingc
Copy link
Contributor

yutingc commented May 6, 2015

Hi @GoodOlClint , thanks for your contribution. The changes look good.
Can you create a pull request to merge to PowerShell:BugFixes? We will merge the changes from other branches into master branch about once a week.

Thanks again for your contribution.

@GoodOlClint
Copy link
Contributor Author

Sure thing.

@GoodOlClint GoodOlClint mentioned this pull request May 6, 2015
Merged
@GoodOlClint GoodOlClint closed this May 6, 2015
@raghushantha raghushantha reopened this May 6, 2015
@msftclas
Copy link

msftclas commented May 6, 2015

Hi @GoodOlClint, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@raghushantha
Copy link
Member

Please add/update unittests for this change.

@yutingc
Copy link
Contributor

yutingc commented May 6, 2015

Close this one. @GoodOlClint, could you please submit another pull request for unit test regarding your changes? Thanks!

Sorry for the confusion.

@yutingc yutingc closed this May 6, 2015
@vors vors removed the in progress label May 6, 2015
@GoodOlClint GoodOlClint mentioned this pull request May 7, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GoodOlClint @msftclas @yutingc @raghushantha @vors